Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ObjectMeta::size for range requests (#5272) #5276

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Fix ObjectMeta::size for range requests (#5272) #5276

merged 4 commits into from
Jan 3, 2024

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Jan 3, 2024

Which issue does this PR close?

Closes #5272

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the object-store Object Store Interface label Jan 3, 2024
@tustvold tustvold mentioned this pull request Jan 3, 2024
Closed
@clbarnes
Copy link
Contributor

clbarnes commented Jan 3, 2024

I was having a bash at this too, by updating header_meta to check for a Content-Range, but it's probably better to do it this way.

@tustvold
Copy link
Contributor Author

tustvold commented Jan 3, 2024

I have tested this against S3, Azure and GCS

alamb
alamb reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me -- thank you @tustvold

The positive case also looks good

I think given this code is parsing results, and has many potential error conditions, the new code should also have test coverage for negative cases

object_store/src/client/get.rs Show resolved Hide resolved
object_store/src/lib.rs Show resolved Hide resolved
@alamb alamb mentioned this pull request Jan 3, 2024
Closed
9 tasks
alamb
alamb approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you @tustvold

@tustvold tustvold merged commit 5a67f1f into apache:master Jan 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
object-store Object Store Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ObjectStore::get_opts Incorrectly Returns Response Size not Object Size
3 participants
@tustvold @clbarnes @alamb